search

MercurialPony / Subterranean-Wilderness

The source code for Subterranean Wilderness, a spiritual successor to WTF's CaveBiomes that aims to spice up the old vanilla caves you got bored of years ago and bring you the cave update you always wanted.
3 stars 5 forks source link

Added Forge item tags for block items. #28

Closed Harleyoc1 closed 3 years ago

Harleyoc1 commented 3 years ago

Copy Forge block tags over to block items, fixes #21.

Harleyoc1 commented 3 years ago

For anyone who wants this issue fixed without waiting for an update, I originally made this as a data pack for a server so you can use this with the current version: SubterraneanWildernessItemTags.zip

PaintNinja commented 3 years ago

Thanks for your PR! Please could you provide some short steps to reproduce the issue so that I can verify that it's fixed?

Harleyoc1 commented 3 years ago

I'm not 100% on whether there is a "proper" way to test it, but here's a simple class I wrote that adds the forge tags for each item onto a tooltip which you could add for testing if you want to check they are being applied to the items in the dev environment.

The other option of course is to just build it and install literally any ore processing mod like Mekanism and you will see that you can now put the ores (such as blackstone iron) into the machines and they are processed as would be expected.

PaintNinja commented 3 years ago

Confirmed that without this patch, SubWild ores such as Blackstone Iron Ore cannot be processed in certain machinery, such as Mekanism's Enrichment machine.