search

MercuryTechnologies / nix-your-shell

A `nix` and `nix-shell` wrapper for shells other than `bash`
MIT License
85 stars 12 forks source link

Add `bash` support #23

Closed 9999years closed 1 year ago

9999years commented 1 year ago

This is a little weird, because bash is the default shell Nix uses. However, we're currently seeing a bug where nix develop will exit if any command being run exits with a nonzero exit code, but nix develop --command bash will not. Weird!

EDIT: The bug was caused by sourcing scripts created with writeShellApplication instead of writeShellScriptBin in the Nix shell's shellHook, causing set -eu being sourced at the beginning of the shell. This in turn caused any failing command to exit the shell. I'm still going to merge this though because bash support won't hurt anyone.

linear[bot] commented 1 year ago
DUX-1092 Add bash support to nix-your-shell

[https://mercurytechnologies.slack.com/archives/C01QJRR7E23/p1678302126852869?thread_ts=1678300301.675419&cid=C01QJRR7E23](https://mercurytechnologies.slack.com/archives/C01QJRR7E23/p1678302126852869?thread_ts=1678300301.675419&cid=C01QJRR7E23)

github-actions[bot] commented 1 year ago

A PR to release these changes has been created, bumping the version from 1.1.1 to 1.2.0.