search

MercuryTechnologies / nix-your-shell

A `nix` and `nix-shell` wrapper for shells other than `bash`
MIT License
85 stars 12 forks source link

feat: add nushell support #35

Closed meskill closed 11 months ago

meskill commented 11 months ago

Hi! Thanks for sending this in!

I haven't used nushell, although I've been watching it from afar and think it's pretty neat. I'll need your expertise here and I'll also want you to maintain the nushell support in nix-your-shell as well — are you willing to do that?

Overall, this PR looks good. Let's move generate-config to nix-your-shell.passthru.generate-config and then I think we can merge this.

Thank you. I'll be glad to help with maintaining the nushell support!

I'll make the requested changes to this mr shortly

meskill commented 11 months ago

Should we change the labels of the mr as it looks like it'll affect version bump action?

9999years commented 11 months ago

Looks good, I'll get this merged and cut a new release.

9999years commented 11 months ago

OK my release CI broke but I got it fixed and shipped this in v1.3.0.