search

MercuryTechnologies / nix-your-shell

A `nix` and `nix-shell` wrapper for shells other than `bash`
MIT License
85 stars 12 forks source link

Fix nushell with --nom, make shell bits templated #62

Closed K900 closed 3 months ago

K900 commented 3 months ago

The nu template uses the executable very differently from others, so it ends up trying weird things like which nix-your-shell --nom, which fails because which doesn't understand --nom.

The other shell templates are also broken as shell scripts, because they rely on the nix-your-shell -> nix-your-shell $shell substitution.

Fix everything by using a real template engine.

9999years commented 3 months ago

sickos yes

9999years commented 3 months ago

I kinda want to get some testing put in (#61) but I can probably just check this by hand to make sure that it works so we don't have to block on #61.

9999years commented 3 months ago

Tested this locally, looks good!

9999years commented 3 months ago

$5 if you can tell me why the 'update versions and push a release PR' job failed lmao https://github.com/MercuryTechnologies/nix-your-shell/actions/runs/8330184312/job/22799988945

K900 commented 3 months ago

Sorry, I know absolutely nothing about Github actions :(

9999years commented 3 months ago

OK I got the release pipeline fixed, tagged here https://github.com/MercuryTechnologies/nix-your-shell/releases/tag/v1.4.4