MercuryWorkshop / anuraOS

A web "OS" and development environment with full linux emulation
https://anura.pro
GNU Affero General Public License v3.0
204 stars 249 forks source link

Add Matter, Minor CSS Changes, SORRY IF PRETTIER FUCKS SOMETHING UP! #132

Closed MadjikDotPng closed 7 months ago

MadjikDotPng commented 7 months ago

If prettier fucks something up PLEASE FIX IT.

velzie commented 7 months ago

maybe you should fix prettier on your end?? it's still changing random things and it shouldn't be up to us to change back all the things it changes

velzie commented 7 months ago

honestly, just disable it outright if this is gonna keep happening

wearrrrr commented 7 months ago

Also, you do know you can preview what files have changed in a commit using vscode right? Or gitlens. You shouldn't have to blindly guess if something has changed because its pretty obvious.

ProgrammerIn-wonderland commented 7 months ago

Also, you do know you can preview what files have changed in a commit using vscode right? Or gitlens. You shouldn't have to blindly guess if something has changed because its pretty obvious.

Yeah but one of the commit hooks is make lint and git add ., so even if you discard the file from the commit it will happen anyways

wearrrrr commented 7 months ago

Yeah but one of the commit hooks is make lint and git add ., so even if you discard the file from the commit it will happen anyways

Fair, they could still review what files changed on the pr creation page though ;-;

ProgrammerIn-wonderland commented 7 months ago

And then do what? Even if they reviewed the files, it's still going to be in history

velzie commented 7 months ago

kid named git commit --amend && git push --force

ProgrammerIn-wonderland commented 7 months ago

Encouraging people to change history seems like a bad idea

sonarcloud[bot] commented 7 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

wearrrrr commented 7 months ago

The issue inside of matter.css needs to be fixed before merging @Endercass, it's literally just an unused css declaration but it's causing quality gate to have a stroke

Endercass commented 7 months ago

i understand but it would be nice for formatting to be fixed so we have a way to track the next people who break the formatting

MadjikDotPng commented 7 months ago

image

I hate you all

wearrrrr commented 7 months ago

I hate you all

Have you tried turning off repo notifications

MadjikDotPng commented 7 months ago

I need it

Endercass commented 7 months ago

then maybe dont complain?

MadjikDotPng commented 7 months ago

Lets move all of MW to this one PR shall we