How not to add a feature

MercuryWorkshop / fakemurk

[UNMAINTAINED] fakemurk - a set of scripts for spoofing verified on an enrolled chromebook

Other

56 stars 19 forks source link

How not to add a feature #40

Closed TheComputerToucher closed 1 year ago

TheComputerToucher commented 1 year ago

It doesn't trip GAC, it should be fine. Unless the user is a stupid skid.

velzie commented 1 year ago

closing this. not only is "fakeapk" a terribly undescriptive and misleading name, the option will also download a random unverified script from an unnassociated repo

this is a low quality hack, not a true fix for the "issue" and i won't be merging in this state

velzie commented 1 year ago

suggestions for a better resolution of the issue:

change the loaded variables from the crossystem.sh mutable path, so you don't need to reboot several times
find the actual code path causing issues, and resolve it in a cleaner way
by checking parent ids, have certain values dynamically be replaced depending on what the invoker is

TheComputerToucher commented 1 year ago

Upon reflection, this was really stupid. I will not do this again, I was very tired when making the patch, and still am. I will not ever do something like this again. I am genuinely sorry for wasting your time, have a nice day. Goodbye.