Meredith-Lab / volcalc

volcalc: Calculate Volatility of Chemical Compounds
https://meredith-lab.github.io/volcalc/
Other
4 stars 1 forks source link

Move `ChemmineOB` to Suggests #101

Closed Aariq closed 3 months ago

Aariq commented 6 months ago

CRAN submission is failing pre-test on Debian because ChemmineOB can't be installed. I think the solution is to follow ChemmineR's lead and put ChemmineOB in Suggests rather than Imports, even though it is required for basic functionality of volcalc.

Steps to take:

Aariq commented 6 months ago

This may not be necessary after all. It may have just been an issue with the DESCRIPTION file of ChemmineOB which has since been fixed. Leaving this open for now though, in case it does need to be done.

Aariq commented 4 months ago

ChemmineOB still causing (different) issues with CRAN, but this still may not be necessary.

Aariq commented 3 months ago

Closing this and the associated draft PR as it is not necessary, especially if this isn't going on CRAN