Meredith-Lab / volcalc

volcalc: Calculate Volatility of Chemical Compounds
https://meredith-lab.github.io/volcalc/
Other
4 stars 1 forks source link

WIP: move ChemmineOB to Suggests #102

Closed Aariq closed 3 months ago

Aariq commented 6 months ago

We think the CRAN pre-test is failing because OpenBabel isn't installed on their Debian runner and is making it impossible to install ChemmineOB. This PR moves ChemmineOB from Imports to Suggests and does a bunch of other things to make this work:

I'm now questioning whether this will even work. I think CRAN tries to install Suggests dependencies as well and I'm not sure what happens if one of those errors.

We should run rhub::check_on_debian() and/or rhub::check_for_cran() on this branch before merging and re-submitting.

Aariq commented 5 months ago

This may not be needed. The CRAN error was due to the formatting of the License field in the DESCRIPTION file of ChemmineOB. Waiting for ChemmineOB to be updated on Bioconductor to try CRAN again (#103)

Aariq commented 3 months ago

Closing because this is likely not necessary, and definitely not necessary if it isn't going on CRAN. Also, it's out of date now.