This fixes killer move generation on the staged move generator, which was bugging in some cases where there were two killer moves but one of them was illegal. Test cases were added.
I accidentally stopped the SPRT test for this patch in the middle, but since this was properly tested and is supposed to fix the behavior of generating killer moves (and the SPRT test, on 83.6%, was on its way to pass), I consider this safe to merge.
SPRT: llr 2.42 (83.6%), lbound -2.25, ubound 2.89
Elo difference: 16.1 +/- 7.7, LOS: 100.0 %, DrawRatio: 47.7 %
Score of Illumina - New vs Illumina - Previous: 1169 - 979 - 1956 [0.523] 4104
This fixes killer move generation on the staged move generator, which was bugging in some cases where there were two killer moves but one of them was illegal. Test cases were added.
I accidentally stopped the SPRT test for this patch in the middle, but since this was properly tested and is supposed to fix the behavior of generating killer moves (and the SPRT test, on 83.6%, was on its way to pass), I consider this safe to merge.
SPRT: llr 2.42 (83.6%), lbound -2.25, ubound 2.89 Elo difference: 16.1 +/- 7.7, LOS: 100.0 %, DrawRatio: 47.7 % Score of Illumina - New vs Illumina - Previous: 1169 - 979 - 1956 [0.523] 4104