search

Mergifyio / daiquiri

Python library to easily setup basic logging functionality
Apache License 2.0
333 stars 25 forks source link

Add documentation for the ExtrasFormatter class. #33

Closed kurtwheeler closed 5 years ago

kurtwheeler commented 5 years ago

I added this feature a long time ago, but I never added anything about it to the docs, so I doubt it's gotten much usage. Finally circling back to do so. Better late than never!

jd commented 5 years ago

pep8 fails

jd commented 5 years ago

Can you squash your commits in a single proper one? :)

kurtwheeler commented 5 years ago

Is there a preferred method you have for doing so? I generally use the 'Squash and Merge` button in Github. Do you not like it for some reason?

jd commented 5 years ago

Yeah, I use Mergify automerge so I don't bother clicking the button and expect branches to be perfectly organized. ;)

I'm against having commits that are "broken" (CI related) in the history, in general (which is the case with your first commit here ;))

kurtwheeler commented 5 years ago

I think this is good to right? Not sure why it's not automerging.

jd commented 5 years ago

You force-pushed so my review has been removed :)