search

Mergifyio / mergify

Mergify Community Issue Tracker
https://mergify.com
Apache License 2.0
318 stars 92 forks source link

Confirmation message for Depends-On: #5050

Open hansen-matt opened 1 year ago

hansen-matt commented 1 year ago

Expected Behavior

Sometimes the changes for feature/B depend on the changes for feature/A. The Depends-On: #1234 syntax allows me to block merging feature/B until the PR for feature/A merges, but a small typo can make that fail silently.

It would be nice if there was an obvious user-facing confirmation that Depends-On: was parsed successfully. One option would be to post a comment, like the existing "Mergify rebased successfully" comment. Another option would be an emoji on the PR description, like what is done when commenting "@mergifyio rebase".

Actual Behavior

depends-on: #1234, depends on: #1234, Depends-On #1234 etc don't create a dependency, but look correct at first glance.

Steps to Reproduce the Problem

  1. Create two PRs
  2. Add Depends-On: #1 to PR #2, but get the syntax wrong
  3. Approve PR #2 and watch it merge automatically

Specifications

jd commented 1 year ago

Hi @hansen-matt,

Those are great suggestions, thank you. I'm not sure how to do this right now:

The emoji reactions are pretty limited. If we could react with 🔗 it could be cool but that's not in the list of allowed reactions. We could edit the body or post a comment though.

For what it's worth, the Summary report posted on the PR will automatically inject a condition for a valid Depends-On which indicates the PR it is waiting for. I imagine it's less visible than an emoji or comment, but the information is there.