Mergifyio / mergify

Mergify Community Issue Tracker
https://mergify.com
Apache License 2.0
318 stars 91 forks source link

Handle ci/circleci tests with a space in the name #5116

Open patrickviet opened 1 week ago

patrickviet commented 1 week ago

Expected Behavior

No syntax error - when using as a check - check-success=ci/circleci: test

As per https://docs.mergify.com/integrations/circleci/ And also as per supposedly repaired on https://github.com/Mergifyio/mergify/issues/233

Actual Behavior

Screen Shot 2024-06-25 at 1 59 26 PM
The current Mergify configuration is invalid
Extra inputs are not permitted @ pull_request_rules → item 0 → conditions → item 1 → check-success=ci/circleci → test
Field required @ pull_request_rules → item 0 → conditions → item 1 → and
Field required @ pull_request_rules → item 0 → conditions → item 1 → or
Field required @ pull_request_rules → item 0 → conditions → item 1 → not

Steps to Reproduce the Problem

use this config file in a branch

pull_request_rules:
  - name: automatic merge
    conditions:
    - label=automerge
    - check-success=ci/circleci: test
    actions:
      queue:
        name: speculative

queue_rules:
  - name: speculative
    queue_conditions:
    - check-success=ci/circleci: test
    speculative_checks: 3

Also doesn't work with check-success="ci/circleci: test"

sileht commented 1 week ago

Hi, this should work:

conditions:
- "check-success=ci/circleci: test"
sileht commented 1 week ago

We will fix the documentation