MerginMaps / mobile

Mobile app for Mergin Maps 📲. Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
295 stars 64 forks source link

Code coverage check incorrectly compares to previous build #2009

Open tomasMizera opened 2 years ago

tomasMizera commented 2 years ago

It seems that code coverage check currently compares coverage to previous build on the same branch. It is fine for master branch, but in feature branches this is wrong due to scenarios like this:

Let's say initial code coverage is 60%,

I guess we should always compare to last master build?

PeterPetrik commented 2 years ago

yep, should compare to master....

tomasMizera commented 2 years ago

See https://github.com/lemurheavy/coveralls-public/issues/1167