MerginMaps / mobile

Mobile app for Mergin Maps 📲. Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
280 stars 62 forks source link

Handling a missing photo in photo field #3410

Closed VitorVieiraZ closed 1 month ago

VitorVieiraZ commented 2 months ago
Indication of the missing photo

Partially fixes #3405

saberraz commented 2 months ago

Thanks Vitor for fixing this issue. Don't we need to show a message about the old photo not being available and if the user does not take any action (i.e. take a new photo or attach one from gallery) we still keep the link between the missing photo and feature. The user might want to fix the issue by restoring the photo from elsewhere (e.g. uploading it through the plugin).

github-actions[bot] commented 2 months ago

Pull Request Test Coverage Report for Build 8969989879

Details


Totals Coverage Status
Change from base Build 8935477302: 0.06%
Covered Lines: 7665
Relevant Lines: 12752

💛 - Coveralls
VitorVieiraZ commented 2 months ago

Thanks Vitor for fixing this issue. Don't we need to show a message about the old photo not being available and if the user does not take any action (i.e. take a new photo or attach one from gallery) we still keep the link between the missing photo and feature. The user might want to fix the issue by restoring the photo from elsewhere (e.g. uploading it through the plugin).

You’re welcome! The message is now applied when the photo is missing. The user has two options: either click on the trash button to remove the missing file from the feature, or fix it, and then the file will be displayed normally when they open the app again.