MerginMaps / mobile

Mobile app for Mergin Maps 📲. Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
280 stars 62 forks source link

Fix ANR when opening project with searchbar focus #3462

Closed tomasMizera closed 1 month ago

tomasMizera commented 1 month ago

Weird bug here.. When we were trying to set visible property of the entire project controller (MMProjectController.qml) to false while searchBar had focus, the app would freeze (ANR). I spent a few hours debugging and have not found anything interesting. I believe this is coming from Qt (most likely https://bugreports.qt.io/browse/QTBUG-123876) as it started to appear in Qt 6.6.0 and even more in 6.6.3. Ideally, the best fix would be to have the MMProjectController instantiated dynamically when needed and not play around with the visible property. However, that would be a massive change for now.

Resolves #3027

Thanks @raherin for all the details in the bug report, they helped a lot! Can you please try this build and see if it fixes the issue also for your phone?

tomasMizera commented 1 month ago

@raherin you will find the build here https://github.com/MerginMaps/mobile/actions/runs/9223933873?pr=3462 (once the build finishes)

github-actions[bot] commented 1 month ago

Pull Request Test Coverage Report for Build 9223933876

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9209557888: 0.02%
Covered Lines: 7664
Relevant Lines: 12790

💛 - Coveralls
tomasMizera commented 1 month ago

Confirmed by @raherin