MerginMaps / mobile

Mobile app for Mergin Maps 📲. Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
280 stars 62 forks source link

Enable predictive text on Android #3464

Closed tomasMizera closed 1 month ago

tomasMizera commented 1 month ago

It seems to be working fine for me now with Qt 6.6.3 without any special hacks we had before. I tested Samsung and Google keyboards and they are working just fine with any type of editors in the form.

Note: to disable predictive text on Android, one needs to either set QT_ANDROID_ENABLE_WORKAROUND_TO_DISABLE_PREDICTIVE_TEXT env variable (this then applies to all inputs) or set Qt.ImhNoPredictiveText | Qt.ImhSensitiveData as inputMethodHints (this then applies only to that one input). See https://bugreports.qt.io/browse/QTBUG-86982?focusedId=706751&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-706751 for more info

Resolves #3434

If the tests are ok, we can close https://github.com/MerginMaps/mobile/issues/1768, https://github.com/MerginMaps/mobile/issues/2471, https://github.com/MerginMaps/mobile/issues/2475 and https://github.com/MerginMaps/mobile/issues/2568

github-actions[bot] commented 1 month ago

Pull Request Test Coverage Report for Build 9253659175

Details


Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 3 78.58%
input/core/merginuserinfo.cpp 3 73.76%
input/app/main.cpp 67 32.75%
<!-- Total: 74 -->
Totals Coverage Status
Change from base Build 9251419383: -0.05%
Covered Lines: 7669
Relevant Lines: 12797

💛 - Coveralls
tomasMizera commented 1 month ago

Hi @jozef-budac, can I ask you to test this one? We need to check entering of text/numbers in the forms and other inputs. We enabled the prediction texts and want to see if everything works fine.

Android build: https://github.com/MerginMaps/mobile/actions/runs/9253659183?pr=3464