MerginMaps / mobile

Mobile app for Mergin Maps 📲. Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
280 stars 62 forks source link

Fixing picture zoom in MMPhotoPreview #3495

Closed VitorVieiraZ closed 2 weeks ago

VitorVieiraZ commented 3 weeks ago

https://github.com/MerginMaps/mobile/assets/155513369/90294263-52b3-464f-8400-2f0c4ed19ed1

Fixes #3465

github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9392575262

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7669
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9392575262

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7669
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9392575262

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7669
Relevant Lines: 12801

💛 - Coveralls
tomasMizera commented 3 weeks ago

The code looks good, let's see if we can get rid of the glitch after pinching

github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9452654945

Details


Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
<!-- Total: 9 -->
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7668
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9452654945

Details


Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
<!-- Total: 9 -->
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7668
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9452654945

Details


Files with Coverage Reduction New Missed Lines %
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
<!-- Total: 9 -->
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7668
Relevant Lines: 12801

💛 - Coveralls
tomasMizera commented 2 weeks ago

Ah, the good old PinchArea vs PinchHandler problem. Let's see if the UX is good-enough even without the DragHandler. Again, we need a minimal reproducible code here @VitorVieiraZ and report it to Qt

VitorVieiraZ commented 2 weeks ago

Report for fixing occasional image jumps: https://bugreports.qt.io/browse/QTBUG-126380