MerginMaps / mobile

Mobile app for Mergin Maps 📲. Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
280 stars 62 forks source link

Fixing app freeze when switching pages #3496

Closed VitorVieiraZ closed 2 weeks ago

VitorVieiraZ commented 3 weeks ago

Prevent freezing by clearing focus from all elements when MMToolbar is clicked on short button delegate(Home, Projects or Explore buttons). Fixes #3389

github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9401139627

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9401139627

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9401139627

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9402120717

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.58%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9382599374: -0.04%
Covered Lines: 7671
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9402120717

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.58%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9382599374: -0.04%
Covered Lines: 7671
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 3 weeks ago

Pull Request Test Coverage Report for Build 9402120717

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.58%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9382599374: -0.04%
Covered Lines: 7671
Relevant Lines: 12801

💛 - Coveralls
uclaros commented 3 weeks ago

I tested the artifact and the issue is mostly fixed! However, when local projects model is empty, which was the case when i first installed the apk, the freeze is still there when trying to switch between any of the three pages.

coveralls commented 2 weeks ago

Pull Request Test Coverage Report for Build 9486857460

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/attributes/attributecontroller.cpp 1 77.37%
input/core/merginapi.cpp 8 78.49%
<!-- Total: 10 -->
Totals Coverage Status
Change from base Build 9382599374: -0.06%
Covered Lines: 7669
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 2 weeks ago

Pull Request Test Coverage Report for Build 9487161223

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 2 weeks ago

Pull Request Test Coverage Report for Build 9487161223

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801

💛 - Coveralls
github-actions[bot] commented 2 weeks ago

Pull Request Test Coverage Report for Build 9487161223

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9382599374: 0.02%
Covered Lines: 7678
Relevant Lines: 12801

💛 - Coveralls
tomasMizera commented 2 weeks ago

Please mark this one WIP: xyz as this is still a draft PR :)

github-actions[bot] commented 2 weeks ago

Pull Request Test Coverage Report for Build 9507086492

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9499997026: 0.08%
Covered Lines: 7679
Relevant Lines: 12800

💛 - Coveralls
github-actions[bot] commented 2 weeks ago

Pull Request Test Coverage Report for Build 9507086492

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9499997026: 0.08%
Covered Lines: 7679
Relevant Lines: 12800

💛 - Coveralls
github-actions[bot] commented 2 weeks ago

Pull Request Test Coverage Report for Build 9507086492

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 9499997026: 0.08%
Covered Lines: 7679
Relevant Lines: 12800

💛 - Coveralls
uclaros commented 2 weeks ago

Works for me too!

tomasMizera commented 2 weeks ago

@VitorVieiraZ Can you please check why the gallery app is failing to build on the CI please?