MerginMaps / mobile

Mergin Maps mobile app 📲 Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
302 stars 65 forks source link

WIP - Fix binding loop in MMListDelegate height calculation #3589

Closed VitorVieiraZ closed 1 week ago

VitorVieiraZ commented 2 months ago

Moved height assignment to Component.onCompleted to break circular dependency between height and implicitHeight. MMListDelegate.qml:43:3: QML MMListDelegate: Binding loop detected for property "height" fixed.

Notes: Setting opacity instead of height to hide invisible items.

Screenshot 2024-10-17 at 10 23 59
github-actions[bot] commented 2 months ago

Pull Request Test Coverage Report for Build 11553196549

Details


Files with Coverage Reduction New Missed Lines %
input/core/merginuserinfo.cpp 1 75.18%
input/app/featuresmodel.cpp 1 68.52%
<!-- Total: 2 -->
Totals Coverage Status
Change from base Build 11550175559: 0.02%
Covered Lines: 7884
Relevant Lines: 13038

💛 - Coveralls
tomasMizera commented 1 month ago

Did this solution help the issue Vitor? Can you please check if buttons on the map are behaving correctly? Especially the one with the streaming mode - when you navigate to edit line/polygon feature geometry

VitorVieiraZ commented 1 month ago

Did this solution help the issue Vitor? Can you please check if buttons on the map are behaving correctly? Especially the one with the streaming mode - when you navigate to edit line/polygon feature geometry

Yes, waning is now fixed and working for these cases.

tomasMizera commented 1 week ago

Let's close this one and retry later