MerginMaps / mobile

Mobile app for Mergin Maps 📲. Open QGIS projects and manage vector data on your phone, even offline 📶 (Android/iOS/Windows app)
https://merginmaps.com
GNU General Public License v2.0
294 stars 64 forks source link

Photo naming expression fails if replacing a photo with the same filename #3600

Open raherin opened 2 weeks ago

raherin commented 2 weeks ago

Replacing a photo on a field that uses a photo naming expression results in the photo not being renamed if the resulting filename is the same as the file being replaced. This can cause issues in cases where a user needs to change the photo attached to a feature where a file naming expression is being used.

To recreate the issue, you can use this project.

  1. Create a project that has a photo attachment field in the survey layer and at least one other field that will have a human readable name with a unique constraint (in this example it is the "name" field).
  2. In Project>Properties>Mergin set an expression that will result in a file name that is unique to the feature but not necessarily unique if another photo is taken for the feature. In the example project we use: to_date(now())||'_'||"name"||'-photo1'
  3. Sync the project from QGIS and download it in the mobile app
  4. Record a new feature and attach a photo in the photo widget then save the feature
  5. Go to More>Local changes to check that the correct photo name has been used for the photo
  6. Select the feature on the map and click 'Edit'
  7. Delete the existing photo and take a new one
  8. Save the feature and go to More>Local changes and the new photo should not have the correct photo name
erpas commented 9 hours ago

https://support.lutraconsulting.co.uk/a/tickets/4940