Robustness/speed fixes to work packages

MerginMaps / work-packages

Mergin Maps Work Packages: manage field surveys for multiple teams

MIT License

7 stars 4 forks source link

Robustness/speed fixes to work packages #62

Closed wonder-sk closed 7 months ago

wonder-sk commented 7 months ago

Fixes #60 - works around geodiff bug by only doing rebase when both diffs are not empty (good practice anyway) Fixes #61 - we were doing diff [wp_base -> master_output] instead of [master_base -> master_output] ... this was creating exceedingly large diffs for larger files, ~and may have cause incorrect merges of data as well~ Fixes #46 - adds DEBUG_DIFFS to wp.py

cc @erpas

PeterPetrik commented 7 months ago

Would it be possible to add some auto test to catch the error you fixed?

wonder-sk commented 7 months ago

Would it be possible to add some auto test to catch the error you fixed?

On a second thought, there should not be a particular bug that would make data merging incorrect, it was just that it was very slow even for reasonably sized data, so no change in behavior