search

Merith-TK / cc-restitched-unmaintained

CC: Tweaked ported for Fabric 1.16.x
Other
10 stars 11 forks source link

Fix Disk Drive & Disk Interaction #45

Closed hugeblank closed 3 years ago

hugeblank commented 3 years ago

Inject Special case into ServerPlayerInteractionManager that handles disks being sneak + right clicked onto disk drives.

Fixes #12

Merith-TK commented 3 years ago

does this work for both putting the disk in, and getting the disk out? also does it work with music discs?

hugeblank commented 3 years ago

does this work for both putting the disk in, and getting the disk out?

It does not work for getting disks out, is something that CC:T does? If I could get confirmation on that then I'll get to working on that.

also does it work with music discs?

Ooh, yeah I missed that. Will fix once I get clarification on the first concern above.

Merith-TK commented 3 years ago

Just tested myself, music discs dont work for it at all, and shift-right clicking does not eject

hugeblank commented 3 years ago

This meaning that this commit is good for a merge? Or do you think it would be a good idea to add support for music discs?

Merith-TK commented 3 years ago

It is good to merge after some testing on my end of course

Jummit commented 3 years ago

There is no need for mixins to allow disks to be injected into disk drives. See how I did it in https://github.com/Jummit/cc-restitched/commit/6f70ebeb6ca93612ab2a85c0710af3bf1f149658 Although I i think they are necessary to make it work with music discs.

hugeblank commented 3 years ago

There is no need for mixins to allow disks to be injected into disk drives. See how I did it in Jummit@6f70ebe Although I i think they are necessary to make it work with music discs.

You're right, there was definitely a smarter approach than this but it accidentally worked out since for parity music discs need to be inserted like floppy disks anyways, as you mention. I'd rather keep it as one mixin than a mixin and a method in another class, for ease of reading.

Jummit commented 3 years ago

Don't forget to allow inserting portable computers.

hugeblank commented 3 years ago

Don't forget to allow inserting portable computers.

good catch! I'll add this soon™️