MerlinVR / USharpVideo

A basic video player made for VRChat using Udon and UdonSharp
MIT License
322 stars 43 forks source link

Add a manual resync button #8

Closed bdunderscore closed 3 years ago

bdunderscore commented 3 years ago

In some cases currently, it can be necessary to restart the video playback, either because a playback error occurred, or in weirder cases when things like youtube-dl failing to get the audio part of a livestream happens. This PR adds a button which stops and restarts playback in these cases.

isjame commented 3 years ago

GOOD,I have tested it and it works, but for some unknown reason, this sync button triggers a BUG that causes the entire player UI to failure.

(Test:Just click the Sync button without pressing any other buttons).

This BUG is also common in the world of PYPYDANCE. I think there should be a code to hide the sync button, like PYPYDANCE, Once the video is invalidated or wrong it will Tips on the screen "please click on the sync button", and then the sync button will be displayed.

MerlinVR commented 3 years ago

This has been added in 1.0 as part of #19