MerlinVR / UdonSharp

An experimental compiler for compiling C# to Udon assembly
MIT License
678 stars 89 forks source link

Add support for searching for alternate invocees for externs #129

Open bdunderscore opened 3 years ago

bdunderscore commented 3 years ago

For certain C# methods, Udon exposes the method via a different type than Roslyn considers it to be defined on. One example is System.Type.Name, which is actually defined in System.Reflection.MemberInfo, but exposed via System.Type.Name.

This change allows U# to locate these alternate extern symbols and use them transparently. We move the logic for checking whether symbols are exposed to udon down into BoundExternMethodInvocation, then teach this class to search declared interfaces and superclasses of the invocation target (rather than the symbol's containing type) for defined externs.

Note that we assume that any exposed extern will match if we find it via a constructed symbol here.