Closed g3o2 closed 7 years ago
It would also be more convenient if fill
be set to none
by default.
The following links would look weird.
```mermaid
graph TB;
A-->B
linkStyle 0 stroke:gray;
B-->C
linkStyle 1 stroke:gray;
C-->A
linkStyle 2 stroke:gray;
![screen shot 2016-11-08 at 23 16 06](https://cloud.githubusercontent.com/assets/12123506/20119607/7d8678aa-a609-11e6-8d8d-affd11e6a61d.png)
The fix would be:
```mermaid
graph TB;
A-->B
linkStyle 0 stroke:gray,fill:none;
B-->C
linkStyle 1 stroke:gray,fill:none;
C-->A
linkStyle 2 stroke:gray,fill:none;
```
![screen shot 2016-11-08 at 23 16 38](https://cloud.githubusercontent.com/assets/12123506/20119616/869173dc-a609-11e6-8a86-e098ce81af3e.png)
Finally, the arrow-head with its dark gray for dark themes is not very legible. The color code gray
should be more legible.
It occurs to me that all this may be related to the preview stylesheets conflict described in #2.
Thanks for pointing this out. Seems that at least in 1.7 the previewHtml functionality used by the plugin has changed. The styles do not work as expected. Investigating...
@g3o2 can you post screen captures of what is displayed on your machine. Also the information about your configuration would be useful.
Done.
Thanks for adding the captures!
Made some initial investigation and so far I have seen on my machine that the rendering of the diagram does not yield always the same result.
Can you check if you get the correct rendering by following this procedure:
Voilà, here's what I've done.
Then,
yes, exactly the same here. seems that the plugin works well only after the second activation and only for the first rendering, subsequent updates are not rendered correctly.
not quite. try closing the code tab after that, then suddenly the preview works again (for that moment of course)
The said issue has reappeared. Do you have any tests in place to check for past issues ?
On which vscode version are you?
It is not possible to test what is actually happening inside the viewer component, beyond the input markup.
I'm on 1.11.2.
That's truly a pity, it would be much more convenient to be able to fetch the styles from the output markup. Hmm, how about providing a markdown file with specs that should work ? (maybe including a png
version to compare with) That way, anyone could perform the tests and notify the issues.
I just tried this plugin for the first time after updating vscode today (there was a reference to this plugin in the release notes).
I'm experiencing this same issue, no arrows visible on the first test diagram (the one shown here).
My vscode is v1.15.1 (windows 32bits build)
In the marketplace, the latest plugin version seems to be 0.0.3 (uploaded a couple days ago), which I don't know how to relate with the releases seen in github (v0.5.0 ?)
Other than that, thanks for the plugin! I'd been longing for this functionality for a while.
published 0.5.1. The arrow tip is white on my machine for dark theme.
Thanks! Got the 0.5.1 from the market, however I still see no arrow tips... Maybe there's something wrong on my end.
Arrows in 0.8.2:
The following code in vscode version 1.7.1 (Mac OS X Sierra) does not draw the links but only the arrows of the links