Mermaid-Chart / vscode-mermaid-preview

Previews Mermaid diagrams
MIT License
142 stars 15 forks source link

arrowhead hardly visible with dark themes #17

Closed g3o2 closed 6 years ago

g3o2 commented 7 years ago

The arrow-head with its dark gray for dark themes is not very legible. The color code gray should be more legible.

for a screenshot, see my second last post from #13

vstirbu commented 7 years ago

The plugin uses the forrest and dark stylesheets from mermaid project without any modifications.

If they are not satisfactory I see two ways forward:

  1. make a change request to mermaid itself.
  2. have a mechanism in this plugin that would allow the user to define additional styles, in the same fashion as the default markdown plugin does.

In any situation, I would not like to maintain stylesheets here.

g3o2 commented 7 years ago

I think ad 1) is not feasible, for it is not a direct behaviour of mermaid itself but due to the combination of vscode and mermaid. But then, I also understand your reluctance for maintaining separate stylesheets, which is not a long term solution. My guess is mermaid will yet have to expose certain settings through their language (e.g. arrow style) instead of "concealing" such settings in the CSS.

In the short run, maybe you could just punctually inject or override a few CSS setings ? A plugin facility sounds certainly appealing but more like a long term endeavour. Plus, it will require users to be familiar with both svg and CSS.

A third idea (highly hypothetical for now) would be to map the mermaid styles to a most used subset of vscode's color theme properties. A bit like mapping highlighting themes, so the coloring would change automatically with some properties of the color theme. This would provide a feasible midway solution to both the user experience and the development maintenance. It would also add a coolish twist to your package and not exclude your option 2).

tauren commented 7 years ago

Same problem here. Has anyone found a workaround so I don't have to change my theme?

vstirbu commented 6 years ago

Arrows in 0.8.2:

screen shot 2018-01-29 at 22 40 35