search

Mermaid-Chart / vscode-mermaid-preview

Previews Mermaid diagrams
MIT License
148 stars 16 forks source link

customizing link style with any color sets `fill` property to `black` instead of `none` #18

Closed g3o2 closed 7 years ago

g3o2 commented 7 years ago

example code

graph TB;
    A-->B;
    linkStyle 0 stroke:red;
    B-->C;
    C-->A;

see #13, my second post for a screenshot

vstirbu commented 7 years ago

Seems like mermaid itself has some problems rendering that snippet (capture from mermaid online editor):

screen shot 2016-11-25 at 07 13 06

g3o2 commented 7 years ago

Given that mermaid is still under first release development, my guess is that this is only the tip of the iceberg. Want to open an issue at mermaid's git or shall I do that ?

vstirbu commented 7 years ago

It would be better if you open it. I'm using only the sequence diagram part of mermaid, so you have better knowledge to follow up this issue already.

g3o2 commented 7 years ago

Looks like someone has done this before us already: \<reference to issue 410 knsv/mermaid removed by myself>

vstirbu commented 7 years ago

As soon as they publish a new version to npm I'll update the plugin.

g3o2 commented 7 years ago

To be clear and sure I have created this issue separately: https://github.com/knsv/mermaid/issues/416

vstirbu commented 7 years ago

The plugin now depends on mermaid 7.0.0.

Is this still an issue?