search

Mermaid-Chart / vscode-mermaid-preview

Previews Mermaid diagrams
MIT License
142 stars 15 forks source link

Unable to use custom mermaid settings #55

Closed bzitzow closed 6 years ago

bzitzow commented 6 years ago

Expected behaviour

In the workspace settings, I have configured:

{
    "mermaid": {
        "sequenceDiagram": {
            "mirrorActors": false,
            "width": 250
        }
    }
}

Actual behaviour

VSCode reports: "Unknown configuration setting" on the string "mermaid". The settings are not applied.

vstirbu commented 6 years ago

Cannot replicate the error. I have used your example configuration in both user and workspace settings and the diagram is generated correctly.

Please provide more information about your environment.

davingreen commented 5 years ago

I'm also having this same issue. Settings are not working in User or Workspace settings; shows "Unknown configuration setting".

image

Mermaid Preview v0.10.1

VS Code Info: Version: 1.29.1 (user setup) Commit: bc24f98b5f70467bc689abf41cc5550ca637088e Date: 2018-11-15T19:13:36.375Z Electron: 2.0.12 Chrome: 61.0.3163.100 Node.js: 8.9.3 V8: 6.1.534.41 Architecture: x64

vstirbu commented 5 years ago

Lets explore further this issue in #57.

alexwall commented 5 years ago

Version Mermaid-Preview 0.12.0

I've tried to set the theme

image

Only one setting is available. See code completion mermaid.arrowMarkerAbsolute

image
vstirbu commented 5 years ago

There are three issues in this thread:

  1. the custom theme is not rendered
  2. the docs are not clear
  3. the settings completion shows only one property

For 1 follow the example in the test folder. For 2 or 3 open separate issues.

Thanks!

alexwall commented 5 years ago

I guess the problem, that I use mermaid in markdown files

Preview as mermaid only (on the right):

image

vs preview as a part of a markdown preview (on the left) :

image

So it seems, that the customisation is not working for markdown embedded previews. I can create a issue for this if you like

vstirbu commented 5 years ago

The issue with customising the theme in the markdown preview is that this extension is not the only one in town that converts the the fenced code into the diagram (e.g. https://github.com/mjbvz/vscode-markdown-mermaid).

I have not tried if both plugins are installed. Not sure what is the best way forward. You could open a issue and I'll try to get @mjbvz's opinion...

alexwall commented 5 years ago

Ok I've created this issues: https://github.com/vstirbu/vscode-mermaid-preview/issues/76