search

Mermaid-Chart / vscode-mermaid-preview

Previews Mermaid diagrams
MIT License
148 stars 16 forks source link

Update to newest Mermaid version #6

Closed fmakowski closed 8 years ago

fmakowski commented 8 years ago

Hi there! I have recently started using your extension. Unfortunately, I cannot easily escape some characters (i.e. ":" cannot be escaped in any way), so I have decided to look for a solution. It seems to be resolved on the Mermaid side though (in version 0.5.2) - which led me to check if the extension is using the newest Mermaid version possible.

It looks like it does not, so my question is: is there any way to update it? Should this be done on the code side or I can do that manually somehow?

Best regards! Filip

vstirbu commented 8 years ago

Thanks for finding the extension useful!

This is strange as the version used in this plugin is 6.0.0, the latest mermaid version published in npm registry. So, it should already have all the features present in 0.5.2.

I'll do a bit of investigation myself...

vstirbu commented 8 years ago

I have tried to use : in labels and notes and it works as expected. The only place where it seems to fail is in the participant.

Can you post here an example of what you try to achieve and what would be the expected result?

fmakowski commented 8 years ago

Here you can see the entity code being changed into the colon symbol itself:

screenshot_20161004_181751

Here is the changelog file of the currently installed Mermaid, and it points to version 0.4.0:

screenshot_20161004_182046

vstirbu commented 8 years ago

That gives an invalid syntax at http://knsv.github.io/mermaid/live_editor/ screen shot 2016-10-04 at 19 37 17

fmakowski commented 8 years ago

@vstirbu right... so you think this is still not solved on the library side? And also, do you have any idea how to explain that my CHANGELOG points to old version?

vstirbu commented 8 years ago

Seems that they have not updated the CHANGELOG in a long time.

Yes, the issue is in the library. You might want to open an issue with mermaid to get more info about why it is not working as expected...

If they fix it fast, I'll update immediately this plugin!

fmakowski commented 8 years ago

Ahh ok, my bad. Sorry for reporting the issue then and thank you for your help!

Best regards, Filip

vstirbu commented 8 years ago

ping back when you have updates! :)