search

Mermaid-Chart / vscode-mermaid-preview

Previews Mermaid diagrams
MIT License
142 stars 15 forks source link

Add syntax highlighting support #62

Open bpruitt-goddard opened 5 years ago

bpruitt-goddard commented 5 years ago

Fixes issue #54. Add syntax highlighting support for embedded markdown (identified as mermaid) and mermaid files. This code is the current latest from the side extension I spun off.

My thought is to maintain that as a separate extension both for people only wanting highlighting, and to keep the changes from causing noise here. I'll merge changes from there back to here as they use the same single syntax file.

vstirbu commented 5 years ago

I'll have to investigate why the tests are failing before merging this.

Also thinking to have a CD solution based in actions so that it would be easier to release new versions...

vstirbu commented 5 years ago

Instead of having the syntax highlighting merged in this plugin, I've added an extension pack to the manifest so that installing this plugin installs also yours (298a7a9a4d51b7ec728e2e0fe64899ab48bbbaf3)

bpruitt-goddard commented 5 years ago

That sounds like a good compromise. Want me to close this PR then?

vstirbu commented 5 years ago

In the long term we should have a single plugin that handles the mermaid related features, but right now I'm not able to allocate much time to fix the pending issues in this repo...

So, lets leave it open for now to keep it as a long term goal. Ok?

bpruitt-goddard commented 5 years ago

Sounds good 👍!