search

Mermaid-Chart / vscode-mermaid-preview

Previews Mermaid diagrams
MIT License
148 stars 16 forks source link

Some font awesome icons is not working #83

Closed robertahazinolx closed 5 years ago

robertahazinolx commented 5 years ago

Expected behaviour

graph LR
  A -->|R| B{B}
  B --> C
  C -->|U| D[fa:fa-hand-paper D]
  D --> E
  D --> F[fa:fa-cog Consumer F]

The both hand-paper and cog icons should appear (screenshot captured from Mermaid Live Editor): Screenshot 2019-07-03 at 16 04 17

Actual behaviour

Only the cog icon appears (screenshot captured from Mermaid Preview extension). Screenshot 2019-07-03 at 16 07 31

It was noticed that this weird behaviour occurs for all icons with composite names.

vstirbu commented 5 years ago

Thanks for bringing this up. It seems that the online editor uses a newer font awesome version.

The upgrade path from 4 to 5 is not that clear so I would appreciate some help in this area...

vstirbu commented 5 years ago

There is a related issue on mermaid (knsv/mermaid/issues/830). The plugin already includes the file but does not seem to work in our case.