Mermouy / flowblade

Automatically exported from code.google.com/p/flowblade
0 stars 0 forks source link

3 point overwrite with 2 source marks and one sequence mark fails #63

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Mark in + out on a source clip
2.Mark in on a sequence
3. press t

What is the expected output? What do you see instead?
I expect the selected region of the clip to replace corresponding region in the 
target track.
instead I get no clip selected pop-up.

In tlineaction.py I find:
def three_point_overwrite_pressed():
    # Check that state is good for edit
    if movemodes.selected_track == -1:
        primary_txt = _("No Clips are selected!")
        secondary_txt = _("You need to select clips to overwrite to perform this edit.")
        dialogutils.info_message(primary_txt, secondary_txt, gui.editor_window.window)
        return

Looking in movemodes.py I can see selected_track = -1 at the top.

if I modify that to say.

if movemodes.selected_track == float("inf"):

it falls through to the next case.

if over_length < range_length:
        monitor_clip_too_short(gui.editor_window.window)

I think it should calculate the out point for the track from the clip outpoint.

Perhaps my interpretation of three point overwrite differs from your intention.
I always took it to mean any three points.

To make it the way I think its supposed be I need to address the cause of
foo/bar/tlineaction.py", line 249, in three_point_overwrite_pressed
out_clip = track.clips[movemodes.selected_range_out]
IndexError: list index out of range.

Reading through the documentation I haven't really been able to understand what 
is meant by move mode... is it when moving clips around within the sequence,
Or the selected editing mode?

What version of the product are you using? On what operating system?
flowblade Version 0.12.0
OS: 3.11.0-12-generic #19-Ubuntu SMP x86_64 x86_64 x86_64 GNU/Linux

Please provide any additional information below.

Is this a one person project?
I can see you're in an very early release version but this an excellent piece 
of work so far, I'm really impressed with what you've done here.

I haven’t actually used it edit anything yet but it looks like a great 
candidate for my next project.

I'll have another read through code at movemodes.py
If I can cobble together a patch I'll send it to you... how would you like to 
receive it?
ps. I have no clue what I'm doing with mercurial.

Peace,
Jake

Original issue reported on code.google.com by j.t.pea...@gmail.com on 2 Feb 2014 at 8:21

GoogleCodeExporter commented 9 years ago
This is Invalid, it is not supposed to work like this.

Original comment by janne.li...@gmail.com on 30 May 2014 at 7:46