Closed kayabaNerve closed 3 years ago
The corrected test fails. While https://github.com/MerosCrypto/Meros/blob/master/src/Database/Consensus/objects/ConsensusObj.nim#L470 has the correct prune code, it's only called if the transaction was beaten with no archived holders. Said code is only called on transactions with archived packets, as its called on the result from Epochs.
Any fix we implement now should survive the Epochs redo, as competing Transactions will finalize at the same time with either system.
Oh. While the test was fixed in that commit, it was also commented out. I really don't want to screw up test summaries by having this test fail. While it'd be good to have the reminder, this didn't suddenly break. This test never worked. This issue should stand well enough on its own.
Fixed a couple months ago with the above. Issue was left open due to an omission.
verifyPruned will pass even if only 1/4 prunes work, and it's not even called due to a height issue.