search

MerosCrypto / Meros

An instant and feeless cryptocurrency for the future, secured by the Merit Caching Consensus Mechanism.
https://meroscrypto.io
Other
82 stars 19 forks source link

Meros will offer Block templates with sketch collisions. #239

Open kayabaNerve opened 4 years ago

kayabaNerve commented 4 years ago

There is a dummy serialize to test for collisions, except it asks for a sketch with 0 elements. The Sketcher immediately returns in this edge case, leaving the miner to infinitely attempt the same template over and over again. Even adding new transactions won't remove the two which are conflicting.

kayabaNerve commented 4 years ago

While looking over the code, this doesn't work, this isn't the issue. I have some theoretically valid code to fix this, which I'll push, yet the bug afflicting DT5.1 is a collision false positive. The check can either be disabled for DT5.1, or fixed, but fixing it requires the protocol.