MerosCrypto / Meros

An instant and feeless cryptocurrency for the future, secured by the Merit Caching Consensus Mechanism.
https://meroscrypto.io
Other
82 stars 19 forks source link

When a reorg happens, a node acting as a Merit Holder who loses their nick still acts with it. #261

Closed kayabaNerve closed 3 years ago

kayabaNerve commented 3 years ago
FAT 2020-12-05 19:10:54.055+00:00 Panic                                      tid=47869 reason="Created a Verification with an invalid signature: Invalid SignedVerification signature."
FAT 2020-12-05 19:10:54.055+00:00 Panic                                      tid=47869 reason="Verify threw an Exception despite not naturally throwing anything: /home/l/Meros/src/MainTransactions.nim(39, 12) `false` Created a Verification with an invalid signature: Invalid SignedVerification signature."
FAT 2020-12-05 19:10:54.055+00:00 Panic                                      tid=47869 reason="addBlock threw an Exception despite catching all Exceptions: /home/l/Meros/src/MainMerit.nim(366, 16) `false` Verify threw an Exception despite not naturally throwing anything: /home/l/Meros/src/MainTransactions.nim(39, 12) `false` Created a Verification with an invalid signature: Invalid SignedVerification signature."

This leads to the following behavior. Bug was found by lauri on our Discord.

kayabaNerve commented 3 years ago

Also this:

FAT 2020-12-05 21:48:43.770+00:00 Panic                                      tid=3834 reason="Failed to add a Claim due to a ValueError: Claim has an invalid Signature."
~/Meros/src/Meros.nim(116) Meros
~/Meros/src/Meros.nim(112) main
~/.nimble/pkgs/chronos-2.5.2/chronos/asyncloop.nim(981) runForever
~/.nimble/pkgs/chronos-2.5.2/chronos/asyncloop.nim(276) poll
~/Meros/src/MainMerit.nim(357) anonymous
~/.choosenim/toolchains/nim-1.2.4/lib/system/assertions.nim(29) failedAssertImpl
~/.choosenim/toolchains/nim-1.2.4/lib/system/assertions.nim(22) raiseAssert
~/.choosenim/toolchains/nim-1.2.4/lib/system/fatal.nim(49) sysFatal
Error: unhandled exception: ~/Meros/src/MainMerit.nim(357, 16) `false` Failed to add a Claim due to a ValueError: Claim has an invalid Signature. [AssertionError]