search

MerosCrypto / Meros

An instant and feeless cryptocurrency for the future, secured by the Merit Caching Consensus Mechanism.
https://meroscrypto.io
Other
83 stars 19 forks source link

getBlockTemplate can be abused to cause massive memory usage. #278

Closed kayabaNerve closed 3 years ago

kayabaNerve commented 3 years ago

By spamming it with requests, it'll continuously create copies of every pending Verification Packet, Instead of using incremental IDs, templates must use the timestamp as an ID. If multiple templates are requested in the same second, it should return the existing template.

kayabaNerve commented 3 years ago

Theoretically fixed in https://github.com/MerosCrypto/Meros/commit/17152a35825db1364dbd4d6f1cb487f9a4c02452. Not merged though..