Open kayabaNerve opened 3 years ago
This issue is NOT for the fact the CI is currently disabled (#254) or failing tests (#165, #210).
This issue is about what the CI doesn't do beyond that. It The CI never ran the Python tests (https://github.com/MerosCrypto/Meros/blob/f8168256fd5bb6d4703fb107e4f0423168e3c40b/Meros.nimble#L117-L119) nor checked the Python code (via pyright/mypy/pylint). In order to be competent, it must run all tests and checks.
Briefly touched upon in #281 due to how improving the CI would provide automatic notifications of issues with contributions.
This issue is NOT for the fact the CI is currently disabled (#254) or failing tests (#165, #210).
This issue is about what the CI doesn't do beyond that. It The CI never ran the Python tests (https://github.com/MerosCrypto/Meros/blob/f8168256fd5bb6d4703fb107e4f0423168e3c40b/Meros.nimble#L117-L119) nor checked the Python code (via pyright/mypy/pylint). In order to be competent, it must run all tests and checks.
Briefly touched upon in #281 due to how improving the CI would provide automatic notifications of issues with contributions.