MerosCrypto / Meros

An instant and feeless cryptocurrency for the future, secured by the Merit Caching Consensus Mechanism.
https://meroscrypto.io
Other
83 stars 19 forks source link

Test for syncing missing Transaction inputs isn't comprehensive. #291

Open kayabaNerve opened 3 years ago

kayabaNerve commented 3 years ago

The test for #215 flat out isn't complete. It creates Datas, yet never sends them.

There's also a separate issue at play when syncing transactions behind Verifications. We try to sync Block Datas, which have an input of a genesis. In that case, we move on in the loop, yet we'll end up unable to add the Data and disconnecting a valid peer. We either need to sync the Block or at least not disconnect the peer in the case.

This will be closed when #215 is expanded and a new test is created for the second part of this issue.