search

MerosCrypto / Meros

An instant and feeless cryptocurrency for the future, secured by the Merit Caching Consensus Mechanism.
https://meroscrypto.io
Other
83 stars 19 forks source link

Meros exits with an error message from GTK when the GUI is used despite no display server running. #301

Open kayabaNerve opened 3 years ago

kayabaNerve commented 3 years ago

This is due to the recent GUI upgrade. Notably, changed functionality in Webview 0.10.0.

https://github.com/webview/webview/issues/571 is the upstream issue and I have submitted a PR to re-enable 0.1.1 functionality.

kayabaNerve commented 3 years ago

Since moving to Wry, we no longer segfault, yet we do error beyond our control and don't print our nice error message. Wry issue 265 being implemented into mc_wry should close this issue. That said, there is an edge case for Linux where WebView is installed yet not usable due to the tty being used/Xorg not being started I'm concerned about.

kayabaNerve commented 3 years ago

While 265 did decrease the chances of this happening, it solely applied to WebView being installed; not being available, as somewhat expected. https://github.com/tauri-apps/tao/issues/74 is the issue with the window creation library for being able to handle this. I also did work out a Linux-only version which would manually implement the specified fix, putting the burden on us to check and maintain, which is here.

Said file does change a null pointer return to returning 1 casted to a pointer. For some reason, things didn't work without it. First it said it was valid before segfaulting because it wasn't, then it returned SIGILL when I added a print statement... really weird behavior. Returning a pointer of 1 just works though.