MerosCrypto / Meros

An instant and feeless cryptocurrency for the future, secured by the Merit Caching Consensus Mechanism.
https://meroscrypto.io
Other
83 stars 19 forks source link

RPC doesn't limit connection count. #305

Open kayabaNerve opened 3 years ago

kayabaNerve commented 3 years ago

While the FD tracker does expect untracked sockets to exist, and has an buffer accordingly, this is meant for internals/the database. While it would be fine to have the RPC fit into this buffer (while still leaving a proper buffer), with the proper documentation, the RPC doesn't limit connection count. This can lead to issues where the RPC sockets stop network connections, especially as I don't believe they time out.