MerosCrypto / asmr

Atomic Swaps for Meros and other cryptocurrencies
MIT License
43 stars 15 forks source link

ASMR will indefinitely wait for a BTC lock, even to the point where if it's published, it's timelock will have expired #11

Open kayabaNerve opened 2 years ago

kayabaNerve commented 2 years ago

This is a DoS which arguably doesn't matter as the counterparty never locks their own funds and can simply kill their ASMR instance if this happens. That said, the time to decide to kill, hit Ctrl^C, and kill could theoretically overlap with the BTC actually being sent which would cause ASMR to move forward (assuming it still has a valid timelock).

If ASMR is expanded past the PoC point, this could cause issues. As of right now, even if ASMR moved forward, I believe it'll solely print an address to send the XMR to? So it's not an issue if it's killed because the user who kills won't then send to the address, if it does proceed to that point.