search

Merott / nativescript-pdf-view

A basic PDF viewer plugin for NativeScript. Now maintained by @madmas: github.com/madmas/nativescript-pdf-view
Other
32 stars 35 forks source link

Android crashes with the 3.0.0 version #20

Closed EddyVerbruggen closed 7 years ago

EddyVerbruggen commented 7 years ago

This constructor requires a second argument. I'll make a PR.

EddyVerbruggen commented 7 years ago

See PR #21

Merott commented 7 years ago

Thank you @EddyVerbruggen.

I had to take your commit and change it slightly in order to pass linting, and the semantic-release commit message format. I've kept you as the author 👍.

I've also added a CONTRIBUTING guide guide so that feature PRs can be accepted without change.