search

Merrit / unit_bargain_hunter

Cross-platform app for comparing prices and finding deals.
https://merritt.codes/bargain/
GNU General Public License v3.0
19 stars 2 forks source link

Tax (Vat/Gst) Inclusive vs Exclusive price #70

Closed RasheedAZ closed 1 year ago

RasheedAZ commented 1 year ago

Hi Kristen. Thank you for making this awesome, useful and beautiful app and releasing it on multiple platforms, especially Flathub.

Can you please also add the option to maybe have a checkbox or toggle for Tax inclusive price per item/location?

This is because while most stores might have the tax included depending on your region, other like warehouse type depos or bulk buy stores often have GST excluded which makes them a huge hassle to compare.

Maybe a customisable tax amount can be set in the settings...?

Thanks :)

Merrit commented 1 year ago

Thanks for the issue! :)

I'm not sure I get quite what you are going for; could you explain a little more, or maybe sketch out the issue/solution or something similar?

For example, how would this look? Which toggle would there be, where, and what exactly would it change?

RasheedAZ commented 1 year ago

When you click the item card, there could be a toggle or checkbox for tax inclusive price. Maybe the default (tax inclusive or exclusive) could be set in the settings? signal-2023-05-19-224745

In the settings screen, user could set the percentage for tax: signal-2023-05-19-224606

Sorry for the horrible drawing :)

Merrit commented 1 year ago

Thanks for the great example! :grinning:

I will give this some thought, see what I can come up with.

Merrit commented 1 year ago

Just an update; I have a couple ideas to implement this, but am a bit busy at the moment. I will take a stab at it when I get some time though. :)

Merrit commented 1 year ago

So as I understand it..

If an item does not include taxes in its price, and this toggle is set "Includes tax" -> false.

Is the goal that the app then grabs the tax percentage from the settings and updates the price it shows to include the tax for you?

RasheedAZ commented 1 year ago

Yes I think that how it should work be if the default assumes that the prices entered by the user already have taxes included.

Merrit commented 1 year ago

Thanks for clarifying, I will take a look at this shortly. :)

Merrit commented 1 year ago

Here's a beta build, please give it a try. :)

UnitBargainHunter-Linux-Portable.tar.gz

RasheedAZ commented 1 year ago

Thanks. Didn't realize this was done. Just tried and seems to work great. There's one thing I noticed that can be improved but I'll make a new issue for it.