Merrit / unit_bargain_hunter

Cross-platform app for comparing prices and finding deals.
https://merritt.codes/bargain
GNU General Public License v3.0
20 stars 2 forks source link

Website link broken #84

Closed m3thm4th closed 1 month ago

m3thm4th commented 1 month ago

The link this project points to is broken

Merrit commented 1 month ago

How so? It seems to work on my end:

image

m3thm4th commented 1 month ago

Apparently a "Page Not Found" is loaded first, then the page in your screenshot is loaded with JS. If JS is disabled the visitor is served the "Page Not Found" page.

Merrit commented 1 month ago

I think I see the issue. Please try this link and see if it works for you.

m3thm4th commented 1 month ago

The link works only if there is no / at the end, which some browsers add automatically. so https://merritt.codes/bargain works, but https://merritt.codes/bargain/ doesn't.

Merrit commented 1 month ago

What browser adds the trailing slash automatically? I don't see such behaviour on Firefox or Chrome, on Linux.

m3thm4th commented 1 month ago

On Firefox for example I often encounter this. Anyway, this is the first time the final / creates an issue? iS it a misconfiguration with the back end?

Merrit commented 1 month ago

Seems to be a quirk of the backend that having a trailing slash causes issues yeah, depending on where the site is hosted.

Since the link without the extra backslash works for both of us, I've gone ahead and updated the links to conform to that.

Thanks for opening the issue and letting me know about the problem! :blue_heart:

m3thm4th commented 1 month ago

The issue is still there, I still see "Page Not Found" with JS disabled

Merrit commented 1 month ago

It happens if you navigate to https://merritt.codes/bargain ?

or from a specific link?

m3thm4th commented 1 month ago

It happens when I navigate to https://merritt.codes/bargain/

Merrit commented 1 month ago

Right, that's with the trailing slash. That's an upstream 3rd party issue, so I updated all the links (on the website, in the repo) to a version without the trailing slash, so the links users actually click on should be okay now. Did I miss any?

m3thm4th commented 1 month ago

Did I miss any?

The most obvious is this

Merrit commented 1 month ago

Yep, I missed that one. Fixed now. Thanks! :)