search

Merry3750 / scorigami

This project is dedicated to tracking all scorigami throughout history and keeping the scorigami chart up to date at all times.
http://NFLScorigami.com
MIT License
54 stars 19 forks source link

Sort games by date instead of ID #48

Closed randomidiot13 closed 1 year ago

randomidiot13 commented 1 year ago

ID is mostly though not fully correlated with date, which occasionally leads to strange game orders. Sorting by date, with ID as a secondary key to ensure consistency, is probably more intuitive and helpful.

Merry3750 commented 1 year ago

Good catch. I added this change but implemented it slightly differently

https://github.com/ACMerriman/scorigami/commit/69fac5512ff9162228130affeb19c046c1d3c4c8

randomidiot13 commented 1 year ago

Your implementation doesn't seem to work properly. The dates are timestamp strings, so subtracting them just gives NaN. Interestingly, this appears to have the effect of putting currently playing games at the front.