search

Merry3750 / scorigami

This project is dedicated to tracking all scorigami throughout history and keeping the scorigami chart up to date at all times.
http://NFLScorigami.com
MIT License
54 stars 19 forks source link

Incorrectly deciding how many games are in last row when determining. borders #55

Closed briansayre closed 1 year ago

briansayre commented 1 year ago

image

in source.js onResize() we have:

var numInLastRow = (liveGameContainers.length % numPossibleInRow);
if (numPossibleInRow === 4) {
    numInLastRow = 4;
} else if (numInLastRow === 0) {
    numInLastRow = numPossibleInRow;
}

This causes us to incorrectly remove the bottom border as seen in the picture of the last 4.

code should just be: 

var numInLastRow = (liveGameContainers.length % numPossibleInRow);
if (numInLastRow === 0) {
    numInLastRow = numPossibleInRow;
}