search

Mesabloo / diagnose

A simple library for reporting compiler/interpreter errors
https://hackage.haskell.org/package/diagnose
BSD 3-Clause "New" or "Revised" License
258 stars 19 forks source link

Consider bumping dependencies / GHC version #18

Open luc-tielen opened 1 year ago

luc-tielen commented 1 year ago

In my fork of this repo, I bumped text and hashable to newer versions. It seems to compile and work in my compiler, so maybe worth the time to upgrade?

You can find the commit here: https://github.com/Mesabloo/diagnose/commit/98653e2537445b5fb9d4aeb5477d9bf630d5bebd

Mesabloo commented 1 year ago

Thanks for the issue.

I do not quite understand the point of restricting the version range downwards. For example, all the code works great with say text v1. While this may be an old version, perhaps some people are still using it. As for the upwards bump, if it fully compiles with text v2.* then I'm all for it! And for the version of GHC used in local development, I guess this could be bumped one way or another without harming the codebase. Most of it is standard Haskell 2010 anyway (without much use of extensions...yet).

luc-tielen commented 1 year ago

You're right, not strictly necessary. It was made in a hurry while checking if this change worked. :) Feel free to modify the diff as you want, but atleast you now know it is possible!