search

Mesabloo / diagnose

A simple library for reporting compiler/interpreter errors
https://hackage.haskell.org/package/diagnose
BSD 3-Clause "New" or "Revised" License
257 stars 18 forks source link

Use < 2.2 as upper bound for text #23

Closed byorgey closed 11 months ago

byorgey commented 11 months ago

It's a bit strange to have <= 2.0 as the bound for text since it means that version 2.0 is allowed but not 2.0.1 or 2.0.2. I checked that diagnose builds cleanly and all the tests pass with both text-2.0.2 and text-2.1.

Mesabloo commented 11 months ago

Thanks for your contribution. There was a time where this dependency was useful, but I can't seem to find any import of Data.Text anywhere in the (old) code (excluding tests). Turns out that I already relaxed the bounds in the test suite for the text package: https://github.com/Mesabloo/diagnose/blob/0f17c071d0b00f56a5aabe06f756863d0baca13f/package.yaml#L105C5-L105C25 So I guess there's no need for this dependency anymore, at least not at the library level. Could you check if you can remove it entirely?

byorgey commented 11 months ago

Oh, good call! Yes, it seems we can, see #24 .