MeshToolkit / MSTK

Infrastructure library for reading, writing, querying and manipulating distributed, general unstructured polyhedral meshes
Other
29 stars 10 forks source link

set_target_properties(UnitTest++::UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS}) #122

Open fengsim opened 2 years ago

fengsim commented 2 years ago

do we need to change "UnitTest++" to "UnitTest++::UnitTest++"?

set_target_properties(UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS})

set_target_properties(UnitTest++::UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS})

raovgarimella commented 2 years ago

Possibly. I need to test it first.


From: fengsim @.***> Sent: Sunday, April 17, 2022 4:47:36 AM To: MeshToolkit/MSTK Cc: Subscribed Subject: [EXTERNAL] [MeshToolkit/MSTK] set_target_properties(UnitTest++::UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS}) (Issue #122)

do we need to change "UnitTest++" to "UnitTest++::UnitTest++"?

set_target_properties(UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS})

set_target_properties(UnitTest++::UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS})

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/MeshToolkit/MSTK/issues/122__;!!Bt8fGhp8LhKGRg!UTAczNCrHN2DkAxWOGRw5LZndNrLaR9Q-QrXAw6sjwpDf6reuhAJp7RB07W2$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEBAZQGRFPLPMVVUSGCIXSDVFPT4RANCNFSM5TTWNCWQ__;!!Bt8fGhp8LhKGRg!UTAczNCrHN2DkAxWOGRw5LZndNrLaR9Q-QrXAw6sjwpDf6reuhAJp7QR4TrQ$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

fengsim commented 2 years ago

I have tested it. You could confirm it again. Thanks.

raovgarimella commented 2 years ago

Are you talking about making this change at line 285 of the top level CMakeLists.txt?

That didn't work for me because only UnitTest++ is defined as a target, not UnitTest++::UnitTest++. It is possible you are using a newer version of UnitTest++ in which it is defined.


From: Garimella, Rao Sent: Tuesday, April 26, 2022 10:33:37 AM To: MeshToolkit/MSTK; MeshToolkit/MSTK Cc: Subscribed Subject: Re: [EXTERNAL] [MeshToolkit/MSTK] set_target_properties(UnitTest++::UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS}) (Issue #122)

Possibly. I need to test it first.


From: fengsim @.***> Sent: Sunday, April 17, 2022 4:47:36 AM To: MeshToolkit/MSTK Cc: Subscribed Subject: [EXTERNAL] [MeshToolkit/MSTK] set_target_properties(UnitTest++::UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS}) (Issue #122)

do we need to change "UnitTest++" to "UnitTest++::UnitTest++"?

set_target_properties(UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS})

set_target_properties(UnitTest++::UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES ${UnitTest++_INCLUDE_DIRS})

— Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https://github.com/MeshToolkit/MSTK/issues/122__;!!Bt8fGhp8LhKGRg!UTAczNCrHN2DkAxWOGRw5LZndNrLaR9Q-QrXAw6sjwpDf6reuhAJp7RB07W2$, or unsubscribehttps://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AEBAZQGRFPLPMVVUSGCIXSDVFPT4RANCNFSM5TTWNCWQ__;!!Bt8fGhp8LhKGRg!UTAczNCrHN2DkAxWOGRw5LZndNrLaR9Q-QrXAw6sjwpDf6reuhAJp7QR4TrQ$. You are receiving this because you are subscribed to this thread.Message ID: @.***>

fengsim commented 2 years ago

at line 281 set_target_properties(UnitTest++::UnitTest++ PROPERTIES yes i used the newest UnitTest++.

fengsim commented 2 years ago

if i use 'set_target_properties(UnitTest++ PROPERTIES' and run do-configure-mstk, i will get CMake Error at CMakeLists.txt:281 (set_target_properties): set_target_properties Can not find target to add properties to: UnitTest++

fengsim commented 2 years ago

At line 54-64 in UnitTest++Targets.cmake from UnitTest++, they also use

Create imported target UnitTest++::UnitTest++

add_library(UnitTest++::UnitTest++ STATIC IMPORTED)

set_target_properties(UnitTest++::UnitTest++ PROPERTIES INTERFACE_INCLUDE_DIRECTORIES "/usr/local/include/UnitTest++" )