Mesnage-Org / pgfinder

Peptidoglycan MS1 Analysis Tool
https://mesnage-org.github.io/pgfinder
GNU Lesser General Public License v3.0
4 stars 2 forks source link

Switching to RTD theme #236

Closed ns-rse closed 9 months ago

ns-rse commented 9 months ago

In an attempt to get multiple versions of docs built on ReadTheDocs I've switched themes to the RTD theme. At the same time I noticed the automatic building of API documentation was not happening so I've (hopefully) rendered that and it will be available across all versions going forward.

Not yet sure whether the "flyout" menu will be rendered, its not shown locally and a thread referenced problems in the past and there are some issues on GitHub but these appear to have been resolved.

codecov[bot] commented 9 months ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (ea97fdd) 69.37% compared to head (a48bbb5) 69.37%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #236 +/- ## ======================================= Coverage 69.37% 69.37% ======================================= Files 11 11 Lines 493 493 ======================================= Hits 342 342 Misses 151 151 ```

:umbrella: View full report in Codecov by Sentry.

:loudspeaker: Have feedback on the report? Share it here.

ns-rse commented 9 months ago

I had some merge conflicts with this PR as a result of #227 being merged.

Resolved them locally but now tests fail because of a missing pgfinder/pgfinder/masses I have a lib/pgfinder/masses/ directory in this branch but its empty.

Not familiar with Playwright testing frame work (nor Svelte!) any thoughts/advice welcome @TheLostLambda

TheLostLambda commented 9 months ago

Sorry for breaking things! I'll take a look!

TheLostLambda commented 9 months ago

@ns-rse Not your fault at all! The playwright testing has a test that checks all of the links on the website are live and go where they should! One of those links points to the master branch folder that should contain the mass libraries, but that folder was moved after I merged my PR!

I'll merge this in, then fix that test with another PR in a moment! This PR doesn't break the code — it's already broken!

ns-rse commented 9 months ago

Brilliant, thanks @TheLostLambda